From 318f23befc1acd4cf7326a929738d37e1677da25 Mon Sep 17 00:00:00 2001 From: havoc Date: Fri, 10 Oct 2003 04:42:37 +0000 Subject: [PATCH] one more reminder that nested for(i) loops are bad, mmk? git-svn-id: svn://svn.icculus.org/twilight/trunk/darkplaces@3562 d7cf8633-e32d-0410-b094-e92efae38249 --- model_brush.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/model_brush.c b/model_brush.c index 4470a42d..bf061151 100644 --- a/model_brush.c +++ b/model_brush.c @@ -4569,7 +4569,7 @@ extern void R_Q3BSP_DrawShadowVolume(struct entity_render_s *ent, vec3_t relativ extern void R_Q3BSP_DrawLight(struct entity_render_s *ent, vec3_t relativelightorigin, vec3_t relativeeyeorigin, float lightradius, float *lightcolor, const matrix4x4_t *matrix_modeltofilter, const matrix4x4_t *matrix_modeltoattenuationxyz, const matrix4x4_t *matrix_modeltoattenuationz); void Mod_Q3BSP_Load(model_t *mod, void *buffer) { - int i; + int i, j; q3dheader_t *header; float corner[3], yawradius, modelradius; @@ -4666,10 +4666,10 @@ void Mod_Q3BSP_Load(model_t *mod, void *buffer) mod->radius = modelradius; mod->radius2 = modelradius * modelradius; - for (i = 0;i < mod->brushq3.data_thismodel->numfaces;i++) - if (mod->brushq3.data_thismodel->firstface[i].texture->renderflags & Q3MTEXTURERENDERFLAGS_SKY) + for (j = 0;j < mod->brushq3.data_thismodel->numfaces;j++) + if (mod->brushq3.data_thismodel->firstface[j].texture->renderflags & Q3MTEXTURERENDERFLAGS_SKY) break; - if (i < mod->brushq3.data_thismodel->numfaces) + if (j < mod->brushq3.data_thismodel->numfaces) mod->DrawSky = R_Q3BSP_DrawSky; } } -- 2.39.2