From 364bb1550abd7e586b3c148dfe2fb80eb73e48c9 Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Fri, 10 Oct 2003 04:33:12 +0000 Subject: [PATCH] dont set ret unless you will be returning TRUE --- openbox/prop.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/openbox/prop.c b/openbox/prop.c index 16ab60cb..98bbbd99 100644 --- a/openbox/prop.c +++ b/openbox/prop.c @@ -289,12 +289,16 @@ gboolean prop_get_string_locale(Window win, Atom prop, char **ret) { char **list; int nstr; + char *s; if (get_stringlist(win, prop, &list, &nstr) && nstr) { - *ret = g_convert(list[0], strlen(list[0]), "UTF-8", "ISO-8859-1", + s = g_convert(list[0], strlen(list[0]), "UTF-8", "ISO-8859-1", NULL, NULL, NULL); XFreeStringList(list); - if (*ret) return TRUE; + if (s) { + *ret = s; + return TRUE; + } } return FALSE; } -- 2.39.2