]> icculus.org git repositories - mikachu/openbox.git/commit
Fix list traversal issue in client_calc_layer
authorpldubouilh <pldubouilh@gmail.com>
Fri, 17 Mar 2023 17:23:47 +0000 (18:23 +0100)
committerMikael Magnusson <mikachu@gmail.com>
Mon, 20 Mar 2023 06:28:02 +0000 (07:28 +0100)
commitd41128e5a1002af41c976c8860f8299cfcd3cd72
tree0f002120f9746192748cf54b74382bcc7aad7a3d
parent8c5099bd06f37bc84d979e2aacc637ea5779ab09
Fix list traversal issue in client_calc_layer

The calls to client_calc_layer_internal can modify stacking_list, which
can cause us to follow dangling ->next pointers (either by the pointer
itself already being freed, or it pointing to a freed area). Avoid this
by copying the list first, the goal is to visit every client in the list
once so this should be fine.
openbox/client.c