From 38c82eecd418a4354cb17beac15c55cd26811c27 Mon Sep 17 00:00:00 2001 From: Rudolf Polzer Date: Wed, 27 Jan 2010 16:12:53 +0100 Subject: [PATCH] code cleanups in preparation of autocvars --- data/balance.cfg | 2 +- data/balance25.cfg | 2 +- data/balanceHavoc.cfg | 2 +- data/balanceNexrun.cfg | 2 +- data/balanceSamual.cfg | 2 +- data/qcsrc/server/campaign.qc | 4 ++-- data/qcsrc/server/cheats.qc | 1 - data/qcsrc/server/cheats.qh | 2 ++ data/qcsrc/server/cl_client.qc | 4 ++-- data/qcsrc/server/g_damage.qc | 9 +------- data/qcsrc/server/g_world.qc | 11 +--------- data/qcsrc/server/miscfunctions.qc | 22 +++---------------- data/qcsrc/server/monsters/ai.qc | 2 ++ data/qcsrc/server/monsters/defs.qc | 2 ++ ...anagement.qc => mode_management.qc.unused} | 4 ++-- data/qcsrc/server/teamplay.qc | 4 +++- data/qcsrc/server/vote.qc | 4 ++-- data/qcsrc/server/w_campingrifle.qc | 2 +- data/qcsrc/server/w_rocketlauncher.qc | 11 ---------- 19 files changed, 28 insertions(+), 64 deletions(-) rename data/qcsrc/server/monsters/{mode_management.qc => mode_management.qc.unused} (99%) diff --git a/data/balance.cfg b/data/balance.cfg index 2f7c631d2..071a80fae 100644 --- a/data/balance.cfg +++ b/data/balance.cfg @@ -507,7 +507,7 @@ set g_balance_hlac_secondary_shots 6 // {{{ campingrifle set g_balance_campingrifle_magazinecapacity 0 set g_balance_campingrifle_reloadtime 2 // matches reload anim -set g_balance_campingrifle_auto_reload_after_changing_weapons 0 +set g_balance_campingrifle_auto_reload_on_switch 0 set g_balance_campingrifle_bursttime 0.85 // 0.35 - 0.1 + 0.35 - 0.1 + 0.35 = three secondaries set g_balance_campingrifle_tracer 1 set g_balance_campingrifle_primary_damage 50 diff --git a/data/balance25.cfg b/data/balance25.cfg index bcfa0bab4..ae95ac867 100644 --- a/data/balance25.cfg +++ b/data/balance25.cfg @@ -506,7 +506,7 @@ set g_balance_hlac_secondary_shots 6 // {{{ campingrifle set g_balance_campingrifle_magazinecapacity 8 set g_balance_campingrifle_reloadtime 2 // matches reload anim -set g_balance_campingrifle_auto_reload_after_changing_weapons 0 +set g_balance_campingrifle_auto_reload_on_switch 0 set g_balance_campingrifle_bursttime 0 set g_balance_campingrifle_tracer 0 set g_balance_campingrifle_primary_damage 60 diff --git a/data/balanceHavoc.cfg b/data/balanceHavoc.cfg index 3fad57af3..052c43fec 100644 --- a/data/balanceHavoc.cfg +++ b/data/balanceHavoc.cfg @@ -506,7 +506,7 @@ set g_balance_hlac_secondary_shots 5 // {{{ campingrifle set g_balance_campingrifle_magazinecapacity 0 set g_balance_campingrifle_reloadtime 2 // matches reload anim -set g_balance_campingrifle_auto_reload_after_changing_weapons 0 +set g_balance_campingrifle_auto_reload_on_switch 0 set g_balance_campingrifle_bursttime 0.85 // 0.35 - 0.1 + 0.35 - 0.1 + 0.35 = three secondaries set g_balance_campingrifle_tracer 1 set g_balance_campingrifle_primary_damage 50 diff --git a/data/balanceNexrun.cfg b/data/balanceNexrun.cfg index f30dabd6d..d3bde7791 100644 --- a/data/balanceNexrun.cfg +++ b/data/balanceNexrun.cfg @@ -507,7 +507,7 @@ set g_balance_hlac_secondary_shots 5 // {{{ campingrifle set g_balance_campingrifle_magazinecapacity 0 set g_balance_campingrifle_reloadtime 2 // matches reload anim -set g_balance_campingrifle_auto_reload_after_changing_weapons 0 +set g_balance_campingrifle_auto_reload_on_switch 0 set g_balance_campingrifle_bursttime 0.85 // 0.35 - 0.1 + 0.35 - 0.1 + 0.35 = three secondaries set g_balance_campingrifle_tracer 1 set g_balance_campingrifle_primary_damage 50 diff --git a/data/balanceSamual.cfg b/data/balanceSamual.cfg index 6481b6fb5..025ebfb95 100644 --- a/data/balanceSamual.cfg +++ b/data/balanceSamual.cfg @@ -507,7 +507,7 @@ set g_balance_hlac_secondary_shots 6 // {{{ campingrifle set g_balance_campingrifle_magazinecapacity 0 set g_balance_campingrifle_reloadtime 2 // matches reload anim -set g_balance_campingrifle_auto_reload_after_changing_weapons 0 +set g_balance_campingrifle_auto_reload_on_switch 0 set g_balance_campingrifle_bursttime 0.85 // 0.35 - 0.1 + 0.35 - 0.1 + 0.35 = three secondaries set g_balance_campingrifle_tracer 1 set g_balance_campingrifle_primary_damage 50 diff --git a/data/qcsrc/server/campaign.qc b/data/qcsrc/server/campaign.qc index 8a01a23b2..7f4551391 100644 --- a/data/qcsrc/server/campaign.qc +++ b/data/qcsrc/server/campaign.qc @@ -64,7 +64,7 @@ void CampaignPreInit() { float baseskill; string title; - if(cvar("sv_cheats")) + if(autocvar_sv_cheats) { CampaignBailout("JOLLY CHEATS AHAHAHAHAHAHAH))"); return; @@ -101,7 +101,7 @@ void CampaignPreInit() // copy sv_gravity cvar, as the engine needs it too (sorry, this will mess // with the menu a little still...) - cvar_set_normal("sv_gravity", cvar_string("sv_gravity")); + cvar_set_normal("sv_gravity", ftos(cvar("sv_gravity"))); if(Campaign_Invalid()) return; diff --git a/data/qcsrc/server/cheats.qc b/data/qcsrc/server/cheats.qc index 2d7e26918..77c9d70df 100644 --- a/data/qcsrc/server/cheats.qc +++ b/data/qcsrc/server/cheats.qc @@ -15,7 +15,6 @@ void Drag_MoveDrag(entity from, entity to) { } .float maycheat; float sv_cheats; -float autocvar_sv_cheats; #define CHIMPULSE_SPEEDRUN_INIT 30 #define CHIMPULSE_GIVE_ALL 99 diff --git a/data/qcsrc/server/cheats.qh b/data/qcsrc/server/cheats.qh index cb365a3ba..8c276919c 100644 --- a/data/qcsrc/server/cheats.qh +++ b/data/qcsrc/server/cheats.qh @@ -1,3 +1,5 @@ +float autocvar_sv_cheats; // must... declare... global + float cheatcount_total; .float cheatcount; void CheatInit(); diff --git a/data/qcsrc/server/cl_client.qc b/data/qcsrc/server/cl_client.qc index c23c93d4d..f4eb2c461 100644 --- a/data/qcsrc/server/cl_client.qc +++ b/data/qcsrc/server/cl_client.qc @@ -764,8 +764,8 @@ void FixPlayermodel() if(!teams_matter) if(strlen(cvar_string("sv_defaultplayercolors"))) - if(self.clientcolors != cvar("sv_defaultplayercolors")) - setcolor(self, cvar("sv_defaultplayercolors")); + if(self.clientcolors != stof(cvar_string("sv_defaultplayercolors"))) + setcolor(self, stof(cvar_string("sv_defaultplayercolors"))); } void PlayerTouchExplode(entity p1, entity p2) diff --git a/data/qcsrc/server/g_damage.qc b/data/qcsrc/server/g_damage.qc index 4b5fa6c51..f6167ac38 100644 --- a/data/qcsrc/server/g_damage.qc +++ b/data/qcsrc/server/g_damage.qc @@ -1048,14 +1048,7 @@ float RadiusDamage (entity inflictor, entity attacker, float coredamage, float e if(RadiusDamage_running) { - string save; - print("RadiusDamage called recursively!\n"); - print("Expect stuff to go HORRIBLY wrong.\n"); - print("Causing a stack trace...\n"); - save = cvar_string("prvm_backtraceforwarnings"); - cvar_set("prvm_backtraceforwarnings", "1"); - fclose(-1); // calls VM_Warning - cvar_set("prvm_backtraceforwarnings", save); + backtrace("RadiusDamage called recursively! Expect stuff to go HORRIBLY wrong."); return 0; } diff --git a/data/qcsrc/server/g_world.qc b/data/qcsrc/server/g_world.qc index 544f46db0..cddf1c033 100644 --- a/data/qcsrc/server/g_world.qc +++ b/data/qcsrc/server/g_world.qc @@ -453,15 +453,6 @@ void spawnfunc_worldspawn (void) TemporaryDB = db_create(); - /* - TODO sound pack system - // initialize sound pack system - soundpack = cvar_string("g_soundpack"); - if(soundpack != "") - soundpack = strcat(soundpack, "/"); - soundpack = strzone(soundpack); - */ - // 0 normal lightstyle(0, "m"); @@ -533,7 +524,7 @@ void spawnfunc_worldspawn (void) GameLogInit(); // prepare everything if(cvar("sv_eventlog")) { - s = strcat(cvar_string("sv_eventlog_files_counter"), "."); + s = strcat(ftos(cvar("sv_eventlog_files_counter")), "."); s = strcat(s, ftos(random())); matchid = strzone(s); diff --git a/data/qcsrc/server/miscfunctions.qc b/data/qcsrc/server/miscfunctions.qc index 3a8cf78c3..7512392b4 100644 --- a/data/qcsrc/server/miscfunctions.qc +++ b/data/qcsrc/server/miscfunctions.qc @@ -841,6 +841,8 @@ vector randompos(vector m1, vector m2) return v; }; +//#NO AUTOCVARS START + float g_pickup_shells; float g_pickup_shells_max; float g_pickup_nails; @@ -1336,25 +1338,7 @@ void readlevelcvars(void) readplayerstartcvars(); } -/* -// TODO sound pack system -string soundpack; - -string precache_sound_builtin (string s) = #19; -void(entity e, float chan, string samp, float vol, float atten) sound_builtin = #8; -string precache_sound(string s) -{ - return precache_sound_builtin(strcat(soundpack, s)); -} -void play2(entity e, string filename) -{ - stuffcmd(e, strcat("play2 ", soundpack, filename, "\n")); -} -void sound(entity e, float chan, string samp, float vol, float atten) -{ - sound_builtin(e, chan, strcat(soundpack, samp), vol, atten); -} -*/ +//#NO AUTOCVARS END // Sound functions string precache_sound (string s) = #19; diff --git a/data/qcsrc/server/monsters/ai.qc b/data/qcsrc/server/monsters/ai.qc index 23330cdfc..022fde201 100644 --- a/data/qcsrc/server/monsters/ai.qc +++ b/data/qcsrc/server/monsters/ai.qc @@ -188,6 +188,7 @@ void() monster_spawnwanderpath = void() monster_checkbossflag = { +//#NO AUTOCVARS START #if 0 local float healthboost; local float r; @@ -222,6 +223,7 @@ void() monster_checkbossflag = while (self.colormod_x > 0.6 && self.colormod_y > 0.6 && self.colormod_z > 0.6); } #endif +//#NO AUTOCVARS END }; diff --git a/data/qcsrc/server/monsters/defs.qc b/data/qcsrc/server/monsters/defs.qc index 3be0212af..1fa737979 100644 --- a/data/qcsrc/server/monsters/defs.qc +++ b/data/qcsrc/server/monsters/defs.qc @@ -40,12 +40,14 @@ float AS_MISSILE = 4; float SKILL4_MINALPHA = 0.4; float monsterwander; +//#NO AUTOCVARS START /* monsterwander = cvar("monsterwander"); // monsterwander is always on in skill 5 if (skill >= 5) monsterwander = TRUE; */ +//#NO AUTOCVARS END .float candrown; diff --git a/data/qcsrc/server/monsters/mode_management.qc b/data/qcsrc/server/monsters/mode_management.qc.unused similarity index 99% rename from data/qcsrc/server/monsters/mode_management.qc rename to data/qcsrc/server/monsters/mode_management.qc.unused index b9ebf9183..9119d2206 100644 --- a/data/qcsrc/server/monsters/mode_management.qc +++ b/data/qcsrc/server/monsters/mode_management.qc.unused @@ -164,14 +164,14 @@ string dmmessage; void(string m) setdm = { dmmessage = m; - if (cvar_string("deathmatch") != m) + if (cvar("deathmatch") != stof(m)) cvar_set("deathmatch", m); } void(string m) setteamplay = { dmmessage = m; - if (cvar_string("teamplay") != m) + if (cvar("teamplay") != stof(m)) cvar_set("teamplay", m); } diff --git a/data/qcsrc/server/teamplay.qc b/data/qcsrc/server/teamplay.qc index 7b1a85abc..50a8970e3 100644 --- a/data/qcsrc/server/teamplay.qc +++ b/data/qcsrc/server/teamplay.qc @@ -111,6 +111,7 @@ void ReadGameCvars() prev = cvar("gamecfg"); for(i = 0; i < 2; ++i) { +//#NO AUTOCVARS START found += (g_dm = (!found && (prev != GAME_DEATHMATCH) && cvar("g_dm"))); found += (g_tdm = (!found && (prev != GAME_TEAM_DEATHMATCH) && cvar("g_tdm"))); found += (g_domination = (!found && (prev != GAME_DOMINATION) && cvar("g_domination"))); @@ -125,6 +126,7 @@ void ReadGameCvars() found += (g_race = (!found && (prev != GAME_RACE) && cvar("g_race"))); found += (g_nexball = (!found && (prev != GAME_NEXBALL) && cvar("g_nexball"))); found += (g_cts = (!found && (prev != GAME_CTS) && cvar("g_cts"))); +//#NO AUTOCVARS END if(found) break; @@ -408,7 +410,7 @@ void InitGameplayMode() race_timelimit = cvar("timelimit"); cvar_set("fraglimit", "0"); cvar_set("leadlimit", "0"); - cvar_set("timelimit", cvar_string("g_race_qualifying_timelimit")); + cvar_set("timelimit", ftos(cvar("g_race_qualifying_timelimit"))); } else g_race_qualifying = 0; diff --git a/data/qcsrc/server/vote.qc b/data/qcsrc/server/vote.qc index 9a377f9e8..6ca723dc0 100644 --- a/data/qcsrc/server/vote.qc +++ b/data/qcsrc/server/vote.qc @@ -55,7 +55,7 @@ entity GetKickVoteVictim(string vote, string cmd, entity caller) GetKickVoteVictim_newcommand = strcat(argv(0), " # ", ftos(num_for_edict(e))); if(argv(0) == "kickban") { - GetKickVoteVictim_newcommand = strcat(GetKickVoteVictim_newcommand, " ", cvar_string("g_ban_default_bantime"), " ", cvar_string("g_ban_default_masksize"), " ", reason); + GetKickVoteVictim_newcommand = strcat(GetKickVoteVictim_newcommand, " ", ftos(cvar("g_ban_default_bantime")), " ", ftos(cvar("g_ban_default_masksize")), " ", reason); } else if(argv(0) == "kick") { @@ -358,7 +358,7 @@ void VoteHelp(entity e) { print_to(e, "^7\"^2yes^7\", \"^2no^7\", \"^2abstain^7\" and \"^2dontcare^7\" to make your vote."); print_to(e, "^7If enough of the players vote yes the vote is accepted."); print_to(e, "^7If enough of the players vote no the vote is rejected."); - print_to(e, strcat("^7If neither the vote will timeout after ", cvar_string("sv_vote_timeout"), "^7 seconds.")); + print_to(e, strcat("^7If neither the vote will timeout after ", ftos(cvar("sv_vote_timeout")), "^7 seconds.")); print_to(e, "^7You can call a vote for or execute these commands:"); print_to(e, strcat("^3", cvar_string("sv_vote_commands"), "^7 and maybe further ^3arguments^7")); } diff --git a/data/qcsrc/server/w_campingrifle.qc b/data/qcsrc/server/w_campingrifle.qc index e83137696..efbf7955e 100644 --- a/data/qcsrc/server/w_campingrifle.qc +++ b/data/qcsrc/server/w_campingrifle.qc @@ -186,7 +186,7 @@ float w_campingrifle(float req) weapon_setup(WEP_CAMPINGRIFLE); full = W_CampingRifle_CheckMaxBullets(TRUE); - if(cvar("g_balance_campingrifle_auto_reload_after_changing_weapons")) + if(cvar("g_balance_campingrifle_auto_reload_on_switch")) if(!full) self.campingrifle_bulletcounter = -1; } diff --git a/data/qcsrc/server/w_rocketlauncher.qc b/data/qcsrc/server/w_rocketlauncher.qc index 97772e50f..96f13c47e 100644 --- a/data/qcsrc/server/w_rocketlauncher.qc +++ b/data/qcsrc/server/w_rocketlauncher.qc @@ -232,17 +232,6 @@ void W_Rocket_Think (void) desiredorigin = self.owner.origin + self.owner.view_ofs; olddir = normalize(self.velocity); -#if 0 - // disabled this code because it doesn't do what I want it to do :P - cosminang = cos(cvar("g_balance_rocketlauncher_guidefadeangle") * DEG2RAD); - cosmaxang = cos(cvar("g_balance_rocketlauncher_guidemaxangle") * DEG2RAD); - cosang = desireddir * normalize(self.origin - desiredorigin); - if(cosminang == cosmaxang) - f *= (cosang >= cosminang); - else - f *= bound(0, (cosang - cosmaxang) / (cosminang - cosmaxang), 1); -#endif - // now it gets tricky... we want to move like some curve to approximate the target direction // but we are limiting the rate at which we can turn! goal = desiredorigin + ((self.origin - desiredorigin) * desireddir + cvar("g_balance_rocketlauncher_guidegoal")) * desireddir; -- 2.39.2