From 03316bf3d0bdcbeb475f803297a170df0ef978e7 Mon Sep 17 00:00:00 2001 From: havoc Date: Tue, 12 Sep 2006 05:56:26 +0000 Subject: [PATCH] remove some unsafe optimizations in VM_Files_Init and VM_Files_CloseAll (using memset on the return value of an indexing macro is generally a bad idea, and doesn't improve code readability) git-svn-id: svn://svn.icculus.org/twilight/trunk/darkplaces@6582 d7cf8633-e32d-0410-b094-e92efae38249 --- prvm_cmds.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/prvm_cmds.c b/prvm_cmds.c index 7d43ad99..b3e2e97e 100644 --- a/prvm_cmds.c +++ b/prvm_cmds.c @@ -1505,7 +1505,9 @@ setcolor(clientent, value) void VM_Files_Init(void) { - memset(VM_FILES, 0, sizeof(qfile_t*[MAX_VMFILES])); + int i; + for (i = 0;i < MAX_VMFILES;i++) + VM_FILES[i] = NULL; } void VM_Files_CloseAll(void) @@ -1515,9 +1517,8 @@ void VM_Files_CloseAll(void) { if (VM_FILES[i]) FS_Close(VM_FILES[i]); - //VM_FILES[i] = NULL; + VM_FILES[i] = NULL; } - memset(VM_FILES,0,sizeof(qfile_t*[MAX_VMFILES])); // this should be faster (is it ?) } qfile_t *VM_GetFileHandle( int index ) -- 2.39.2