From b8ba1cff1fdd5447984e83708865f8ba6c7f223a Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Sun, 28 Sep 2003 09:24:22 +0000 Subject: [PATCH] perhaps fix problems of being left in menus without being able to control openbox --- openbox/grab.c | 18 ++++++++++++------ openbox/menuframe.c | 16 ++++++++++------ 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/openbox/grab.c b/openbox/grab.c index 34fd2302..e2784a2d 100644 --- a/openbox/grab.c +++ b/openbox/grab.c @@ -50,11 +50,13 @@ gboolean grab_keyboard(gboolean grab) gboolean ret = FALSE; if (grab) { - if (kgrabs++ == 0) + if (kgrabs++ == 0) { ret = XGrabKeyboard(ob_display, RootWindow(ob_display, ob_screen), FALSE, GrabModeAsync, GrabModeAsync, event_lasttime) == Success; - else + if (!ret) + --kgrabs; + } else ret = TRUE; } else if (kgrabs > 0) { if (--kgrabs == 0) @@ -70,12 +72,14 @@ gboolean grab_pointer(gboolean grab, ObCursor cur) gboolean ret = FALSE; if (grab) { - if (pgrabs++ == 0) + if (pgrabs++ == 0) { ret = XGrabPointer(ob_display, screen_support_win, False, GRAB_PTR_MASK, GrabModeAsync, GrabModeAsync, FALSE, ob_cursor(cur), event_lasttime) == Success; - else + if (!ret) + --pgrabs; + } else ret = TRUE; } else if (pgrabs > 0) { if (--pgrabs == 0) { @@ -91,12 +95,14 @@ gboolean grab_pointer_window(gboolean grab, ObCursor cur, Window win) gboolean ret = FALSE; if (grab) { - if (pgrabs++ == 0) + if (pgrabs++ == 0) { ret = XGrabPointer(ob_display, win, False, GRAB_PTR_MASK, GrabModeAsync, GrabModeAsync, TRUE, ob_cursor(cur), event_lasttime) == Success; - else + if (!ret) + --pgrabs; + } else ret = TRUE; } else if (pgrabs > 0) { if (--pgrabs == 0) { diff --git a/openbox/menuframe.c b/openbox/menuframe.c index 95168d4e..09fce051 100644 --- a/openbox/menuframe.c +++ b/openbox/menuframe.c @@ -591,6 +591,16 @@ void menu_frame_show(ObMenuFrame *self, ObMenuFrame *parent) if (g_list_find(menu_frame_visible, self)) return; + if (menu_frame_visible == NULL) { + /* no menus shown yet */ + if (!grab_pointer(TRUE, OB_CURSOR_NONE)) + return; + if (!grab_keyboard(TRUE)) { + grab_pointer(FALSE, OB_CURSOR_NONE); + return; + } + } + if (parent) { if (parent->child) menu_frame_hide(parent->child); @@ -598,12 +608,6 @@ void menu_frame_show(ObMenuFrame *self, ObMenuFrame *parent) } self->parent = parent; - if (menu_frame_visible == NULL) { - /* no menus shown yet */ - grab_pointer(TRUE, OB_CURSOR_NONE); - grab_keyboard(TRUE); - } - /* determine if the underlying menu is already visible */ for (it = menu_frame_visible; it; it = g_list_next(it)) { ObMenuFrame *f = it->data; -- 2.39.2