xz: Multiple fixes.
authorLasse Collin <lasse.collin@tukaani.org>
Fri, 10 Sep 2010 07:30:33 +0000 (10:30 +0300)
committerLasse Collin <lasse.collin@tukaani.org>
Fri, 10 Sep 2010 07:30:33 +0000 (10:30 +0300)
commitbb0b1004f83cdc4d309e1471c2ecaf9f95ce60c5
treed21a6ca975dbd1ed4d6181281be92eb53c82423c
parent639f8e2af33cf8a184d59ba56b6df7c098679d61
xz: Multiple fixes.

The code assumed that printing numbers with thousand separators
and decimal points would always produce only US-ASCII characters.
This was used for buffer sizes (with snprintf(), no overflows)
and aligning columns of the progress indicator and --list. That
assumption was wrong (e.g. LC_ALL=fi_FI.UTF-8 with glibc), so
multibyte character support was added in this commit. The old
way is used if the operating system doesn't have enough multibyte
support (e.g. lacks wcwidth()).

The sizes of buffers were increased to accomodate multibyte
characters. I don't know how big they should be exactly, but
they aren't used for anything critical, so it's not too bad.
If they still aren't big enough, I hopefully get a bug report.
snprintf() takes care of avoiding buffer overflows.

Some static buffers were replaced with buffers allocated on
stack. double_to_str() was removed. uint64_to_str() and
uint64_to_nicestr() now share the static buffer and test
for thousand separator support.

Integrity check names "None" and "Unknown-N" (2 <= N <= 15)
were marked to be translated. I had forgot these, plus they
wouldn't have worked correctly anyway before this commit,
because printing tables with multibyte strings didn't work.

Thanks to Marek Černocký for reporting the bug about
misaligned table columns in --list output.
12 files changed:
configure.ac
m4/tuklib_mbstr.m4 [new file with mode: 0644]
src/common/tuklib_mbstr.h [new file with mode: 0644]
src/common/tuklib_mbstr_fw.c [new file with mode: 0644]
src/common/tuklib_mbstr_width.c [new file with mode: 0644]
src/xz/Makefile.am
src/xz/list.c
src/xz/message.c
src/xz/message.h
src/xz/private.h
src/xz/util.c
src/xz/util.h