From ac9d8c58cb2286a98f699fe1b98b56e11c262868 Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Tue, 2 Sep 2003 08:38:03 +0000 Subject: [PATCH] use the new color hash to cache RrColors --- render/color.c | 44 +++++++++++++++++++++++++++++--------------- render/color.h | 3 +++ 2 files changed, 32 insertions(+), 15 deletions(-) diff --git a/render/color.c b/render/color.c index f791b9c4..5fdce391 100644 --- a/render/color.c +++ b/render/color.c @@ -1,5 +1,6 @@ #include "render.h" #include "color.h" +#include "instance.h" #include #include @@ -39,17 +40,27 @@ RrColor *RrColorNew(const RrInstance *inst, gint r, gint g, gint b) /* this should be replaced with something far cooler */ RrColor *out = NULL; XColor xcol; - xcol.red = (r << 8) | r; - xcol.green = (g << 8) | g; - xcol.blue = (b << 8) | b; - if (XAllocColor(RrDisplay(inst), RrColormap(inst), &xcol)) { - out = g_new(RrColor, 1); - out->inst = inst; - out->r = xcol.red >> 8; - out->g = xcol.green >> 8; - out->b = xcol.blue >> 8; - out->gc = None; - out->pixel = xcol.pixel; + gint key; + + key = (r << 24) + (g << 16) + (b << 8); + if ((out = g_hash_table_lookup(RrColorHash(inst), &key))) { + out->refcount++; + } else { + xcol.red = (r << 8) | r; + xcol.green = (g << 8) | g; + xcol.blue = (b << 8) | b; + if (XAllocColor(RrDisplay(inst), RrColormap(inst), &xcol)) { + out = g_new(RrColor, 1); + out->inst = inst; + out->r = xcol.red >> 8; + out->g = xcol.green >> 8; + out->b = xcol.blue >> 8; + out->gc = None; + out->pixel = xcol.pixel; + out->key = key; + out->refcount = 1; + g_hash_table_replace(RrColorHash(inst), &out->key, out); + } } return out; } @@ -59,10 +70,13 @@ RrColor *RrColorNew(const RrInstance *inst, gint r, gint g, gint b) void RrColorFree(RrColor *c) { if (c) { - if (c->pixel) XFreeColors(RrDisplay(c->inst), RrColormap(c->inst), - &c->pixel, 1, 0); - if (c->gc) XFreeGC(RrDisplay(c->inst), c->gc); - g_free(c); + if (--c->refcount < 1) { + g_hash_table_remove(RrColorHash(c->inst), &c->key); + if (c->pixel) XFreeColors(RrDisplay(c->inst), RrColormap(c->inst), + &c->pixel, 1, 0); + if (c->gc) XFreeGC(RrDisplay(c->inst), c->gc); + g_free(c); + } } } diff --git a/render/color.h b/render/color.h index 246af198..64529292 100644 --- a/render/color.h +++ b/render/color.h @@ -15,6 +15,9 @@ struct _RrColor { int b; unsigned long pixel; GC gc; + + gint key; + gint refcount; }; void RrColorAllocateGC(RrColor *in); -- 2.39.2