From 533992f5aae6804eb77b90f70bf032a09a373930 Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Wed, 20 Aug 2003 17:06:08 +0000 Subject: [PATCH] handle the XGetGeomtry failing for button releases --- openbox/mouse.c | 44 +++++++++++++++++++++++++------------------- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/openbox/mouse.c b/openbox/mouse.c index 82b124af..3872b83d 100644 --- a/openbox/mouse.c +++ b/openbox/mouse.c @@ -1,5 +1,6 @@ #include "openbox.h" #include "config.h" +#include "xerror.h" #include "action.h" #include "event.h" #include "client.h" @@ -228,27 +229,32 @@ void mouse_event(ObClient *client, ObFrameContext context, XEvent *e) int junk1, junk2; Window wjunk; guint ujunk, b, w, h; - XGetGeometry(ob_display, e->xbutton.window, - &wjunk, &junk1, &junk2, &w, &h, &b, &ujunk); - if (e->xbutton.x >= (signed)-b && - e->xbutton.y >= (signed)-b && - e->xbutton.x < (signed)(w+b) && - e->xbutton.y < (signed)(h+b)) { - click = TRUE; - /* double clicks happen if there were 2 in a row! */ - if (lbutton == button && - lwindow == e->xbutton.window && - e->xbutton.time - config_mouse_dclicktime <= - ltime) { - dclick = TRUE; - lbutton = 0; + Status s; + xerror_set_ignore(TRUE); + s = XGetGeometry(ob_display, e->xbutton.window, + &wjunk, &junk1, &junk2, &w, &h, &b, &ujunk); + xerror_set_ignore(FALSE); + if (s == Success) { + if (e->xbutton.x >= (signed)-b && + e->xbutton.y >= (signed)-b && + e->xbutton.x < (signed)(w+b) && + e->xbutton.y < (signed)(h+b)) { + click = TRUE; + /* double clicks happen if there were 2 in a row! */ + if (lbutton == button && + lwindow == e->xbutton.window && + e->xbutton.time - config_mouse_dclicktime <= + ltime) { + dclick = TRUE; + lbutton = 0; + } else { + lbutton = button; + lwindow = e->xbutton.window; + } } else { - lbutton = button; - lwindow = e->xbutton.window; + lbutton = 0; + lwindow = None; } - } else { - lbutton = 0; - lwindow = None; } button = 0; -- 2.39.2