Fix a typo causing submenuShowDelay to be ignored (Bug 6019)
[dana/openbox.git] / openbox / menuframe.c
1 /* -*- indent-tabs-mode: nil; tab-width: 4; c-basic-offset: 4; -*-
2
3    menuframe.c for the Openbox window manager
4    Copyright (c) 2006        Mikael Magnusson
5    Copyright (c) 2003-2007   Dana Jansens
6
7    This program is free software; you can redistribute it and/or modify
8    it under the terms of the GNU General Public License as published by
9    the Free Software Foundation; either version 2 of the License, or
10    (at your option) any later version.
11
12    This program is distributed in the hope that it will be useful,
13    but WITHOUT ANY WARRANTY; without even the implied warranty of
14    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
15    GNU General Public License for more details.
16
17    See the COPYING file for a copy of the GNU General Public License.
18 */
19
20 #include "menuframe.h"
21 #include "client.h"
22 #include "menu.h"
23 #include "screen.h"
24 #include "actions.h"
25 #include "event.h"
26 #include "grab.h"
27 #include "openbox.h"
28 #include "config.h"
29 #include "obt/prop.h"
30 #include "obt/keyboard.h"
31 #include "obrender/theme.h"
32
33 #define PADDING 2
34 #define MAX_MENU_WIDTH 400
35
36 #define ITEM_HEIGHT (ob_rr_theme->menu_font_height + 2*PADDING)
37
38 #define FRAME_EVENTMASK (ButtonPressMask |ButtonMotionMask | EnterWindowMask |\
39                          LeaveWindowMask)
40 #define ENTRY_EVENTMASK (EnterWindowMask | LeaveWindowMask | \
41                          ButtonPressMask | ButtonReleaseMask | \
42                          PointerMotionMask)
43
44 GList *menu_frame_visible;
45 GHashTable *menu_frame_map;
46
47 static RrAppearance *a_sep;
48 static guint submenu_show_timer = 0;
49 static guint submenu_hide_timer = 0;
50
51 static ObMenuEntryFrame* menu_entry_frame_new(ObMenuEntry *entry,
52                                               ObMenuFrame *frame);
53 static void menu_entry_frame_free(ObMenuEntryFrame *self);
54 static void menu_frame_update(ObMenuFrame *self);
55 static gboolean submenu_show_timeout(gpointer data);
56 static void menu_frame_hide(ObMenuFrame *self);
57
58 static gboolean submenu_hide_timeout(gpointer data);
59
60 static Window createWindow(Window parent, gulong mask,
61                            XSetWindowAttributes *attrib)
62 {
63     return XCreateWindow(obt_display, parent, 0, 0, 1, 1, 0,
64                          RrDepth(ob_rr_inst), InputOutput,
65                          RrVisual(ob_rr_inst), mask, attrib);
66 }
67
68 static void client_dest(ObClient *client, gpointer data)
69 {
70     GList *it;
71
72     /* menus can be associated with a client, so null those refs since
73        we are disappearing now */
74     for (it = menu_frame_visible; it; it = g_list_next(it)) {
75         ObMenuFrame *f = it->data;
76         if (f->client == client)
77             f->client = NULL;
78     }
79 }
80
81 void menu_frame_startup(gboolean reconfig)
82 {
83     gint i;
84
85     a_sep = RrAppearanceCopy(ob_rr_theme->a_clear);
86     RrAppearanceAddTextures(a_sep, ob_rr_theme->menu_sep_width);
87     for (i = 0; i < ob_rr_theme->menu_sep_width; ++i) {
88         a_sep->texture[i].type = RR_TEXTURE_LINE_ART;
89         a_sep->texture[i].data.lineart.color =
90             ob_rr_theme->menu_sep_color;
91     }
92
93     if (reconfig) return;
94
95     client_add_destroy_notify(client_dest, NULL);
96     menu_frame_map = g_hash_table_new(g_int_hash, g_int_equal);
97 }
98
99 void menu_frame_shutdown(gboolean reconfig)
100 {
101     RrAppearanceFree(a_sep);
102
103     if (reconfig) return;
104
105     client_remove_destroy_notify(client_dest);
106     g_hash_table_destroy(menu_frame_map);
107 }
108
109 ObMenuFrame* menu_frame_new(ObMenu *menu, guint show_from, ObClient *client)
110 {
111     ObMenuFrame *self;
112     XSetWindowAttributes attr;
113
114     self = g_slice_new0(ObMenuFrame);
115     self->obwin.type = OB_WINDOW_CLASS_MENUFRAME;
116     self->menu = menu;
117     self->selected = NULL;
118     self->client = client;
119     self->direction_right = TRUE;
120     self->show_from = show_from;
121
122     attr.event_mask = FRAME_EVENTMASK;
123     self->window = createWindow(obt_root(ob_screen),
124                                 CWEventMask, &attr);
125
126     /* make it a popup menu type window */
127     OBT_PROP_SET32(self->window, NET_WM_WINDOW_TYPE, ATOM,
128                    OBT_PROP_ATOM(NET_WM_WINDOW_TYPE_POPUP_MENU));
129
130     XSetWindowBorderWidth(obt_display, self->window, ob_rr_theme->mbwidth);
131     XSetWindowBorder(obt_display, self->window,
132                      RrColorPixel(ob_rr_theme->menu_border_color));
133
134     self->a_items = RrAppearanceCopy(ob_rr_theme->a_menu);
135
136     window_add(&self->window, MENUFRAME_AS_WINDOW(self));
137     stacking_add(MENUFRAME_AS_WINDOW(self));
138
139     return self;
140 }
141
142 void menu_frame_free(ObMenuFrame *self)
143 {
144     if (self) {
145         while (self->entries) {
146             menu_entry_frame_free(self->entries->data);
147             self->entries = g_list_delete_link(self->entries, self->entries);
148         }
149
150         stacking_remove(MENUFRAME_AS_WINDOW(self));
151         window_remove(self->window);
152
153         RrAppearanceFree(self->a_items);
154
155         XDestroyWindow(obt_display, self->window);
156
157         g_slice_free(ObMenuFrame, self);
158     }
159 }
160
161 ObtIC* menu_frame_ic(ObMenuFrame *self)
162 {
163     /* menus are always used through a grab right now, so they can always use
164        the grab input context */
165     return grab_input_context();
166 }
167
168 static ObMenuEntryFrame* menu_entry_frame_new(ObMenuEntry *entry,
169                                               ObMenuFrame *frame)
170 {
171     ObMenuEntryFrame *self;
172     XSetWindowAttributes attr;
173
174     self = g_slice_new0(ObMenuEntryFrame);
175     self->entry = entry;
176     self->frame = frame;
177
178     menu_entry_ref(entry);
179
180     attr.event_mask = ENTRY_EVENTMASK;
181     self->window = createWindow(self->frame->window, CWEventMask, &attr);
182     self->text = createWindow(self->window, 0, NULL);
183     g_hash_table_insert(menu_frame_map, &self->window, self);
184     g_hash_table_insert(menu_frame_map, &self->text, self);
185     if ((entry->type == OB_MENU_ENTRY_TYPE_NORMAL) ||
186         (entry->type == OB_MENU_ENTRY_TYPE_SUBMENU)) {
187         self->icon = createWindow(self->window, 0, NULL);
188         g_hash_table_insert(menu_frame_map, &self->icon, self);
189     }
190     if (entry->type == OB_MENU_ENTRY_TYPE_SUBMENU) {
191         self->bullet = createWindow(self->window, 0, NULL);
192         g_hash_table_insert(menu_frame_map, &self->bullet, self);
193     }
194
195     XMapWindow(obt_display, self->window);
196     XMapWindow(obt_display, self->text);
197
198     window_add(&self->window, MENUFRAME_AS_WINDOW(self->frame));
199
200     return self;
201 }
202
203 static void menu_entry_frame_free(ObMenuEntryFrame *self)
204 {
205     if (self) {
206         menu_entry_unref(self->entry);
207
208         window_remove(self->window);
209
210         XDestroyWindow(obt_display, self->text);
211         XDestroyWindow(obt_display, self->window);
212         g_hash_table_remove(menu_frame_map, &self->text);
213         g_hash_table_remove(menu_frame_map, &self->window);
214         if ((self->entry->type == OB_MENU_ENTRY_TYPE_NORMAL) ||
215             (self->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU)) {
216             XDestroyWindow(obt_display, self->icon);
217             g_hash_table_remove(menu_frame_map, &self->icon);
218         }
219         if (self->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU) {
220             XDestroyWindow(obt_display, self->bullet);
221             g_hash_table_remove(menu_frame_map, &self->bullet);
222         }
223
224         g_slice_free(ObMenuEntryFrame, self);
225     }
226 }
227
228 void menu_frame_move(ObMenuFrame *self, gint x, gint y)
229 {
230     RECT_SET_POINT(self->area, x, y);
231     self->monitor = screen_find_monitor_point(x, y);
232     XMoveWindow(obt_display, self->window, self->area.x, self->area.y);
233 }
234
235 static void menu_frame_place_topmenu(ObMenuFrame *self, gint *x, gint *y)
236 {
237     gint dx, dy;
238
239     if (config_menu_middle) {
240         gint myx;
241
242         myx = *x;
243         *y -= self->area.height / 2;
244
245         /* try to the right of the cursor */
246         menu_frame_move_on_screen(self, myx, *y, &dx, &dy);
247         self->direction_right = TRUE;
248         if (dx != 0) {
249             /* try to the left of the cursor */
250             myx = *x - self->area.width;
251             menu_frame_move_on_screen(self, myx, *y, &dx, &dy);
252             self->direction_right = FALSE;
253         }
254         if (dx != 0) {
255             /* if didnt fit on either side so just use what it says */
256             myx = *x;
257             menu_frame_move_on_screen(self, myx, *y, &dx, &dy);
258             self->direction_right = TRUE;
259         }
260         *x = myx + dx;
261         *y += dy;
262     } else {
263         gint myx, myy;
264
265         myx = *x;
266         myy = *y;
267
268         /* try to the bottom right of the cursor */
269         menu_frame_move_on_screen(self, myx, myy, &dx, &dy);
270         self->direction_right = TRUE;
271         if (dx != 0 || dy != 0) {
272             /* try to the bottom left of the cursor */
273             myx = *x - self->area.width;
274             myy = *y;
275             menu_frame_move_on_screen(self, myx, myy, &dx, &dy);
276             self->direction_right = FALSE;
277         }
278         if (dx != 0 || dy != 0) {
279             /* try to the top right of the cursor */
280             myx = *x;
281             myy = *y - self->area.height;
282             menu_frame_move_on_screen(self, myx, myy, &dx, &dy);
283             self->direction_right = TRUE;
284         }
285         if (dx != 0 || dy != 0) {
286             /* try to the top left of the cursor */
287             myx = *x - self->area.width;
288             myy = *y - self->area.height;
289             menu_frame_move_on_screen(self, myx, myy, &dx, &dy);
290             self->direction_right = FALSE;
291         }
292         if (dx != 0 || dy != 0) {
293             /* if didnt fit on either side so just use what it says */
294             myx = *x;
295             myy = *y;
296             menu_frame_move_on_screen(self, myx, myy, &dx, &dy);
297             self->direction_right = TRUE;
298         }
299         *x = myx + dx;
300         *y = myy + dy;
301     }
302 }
303
304 static void menu_frame_place_submenu(ObMenuFrame *self, gint *x, gint *y)
305 {
306     gint overlapx, overlapy;
307     gint bwidth;
308
309     overlapx = ob_rr_theme->menu_overlap_x;
310     overlapy = ob_rr_theme->menu_overlap_y;
311     bwidth = ob_rr_theme->mbwidth;
312
313     if (self->direction_right)
314         *x = self->parent->area.x + self->parent->area.width -
315             overlapx - bwidth;
316     else
317         *x = self->parent->area.x - self->area.width + overlapx + bwidth;
318
319     *y = self->parent->area.y + self->parent_entry->area.y;
320     if (config_menu_middle)
321         *y -= (self->area.height - (bwidth * 2) - ITEM_HEIGHT) / 2;
322     else
323         *y += overlapy;
324 }
325
326 void menu_frame_move_on_screen(ObMenuFrame *self, gint x, gint y,
327                                gint *dx, gint *dy)
328 {
329     const Rect *a = NULL;
330     Rect search = self->area;
331     gint pos, half, monitor;
332
333     *dx = *dy = 0;
334     RECT_SET_POINT(search, x, y);
335
336     if (self->parent)
337         monitor = self->parent->monitor;
338     else
339         monitor = screen_find_monitor(&search);
340
341     a = screen_physical_area_monitor(monitor);
342
343     half = g_list_length(self->entries) / 2;
344     pos = g_list_index(self->entries, self->selected);
345
346     /* if in the bottom half then check this stuff first, will keep the bottom
347        edge of the menu visible */
348     if (pos > half) {
349         *dx = MAX(*dx, a->x - x);
350         *dy = MAX(*dy, a->y - y);
351     }
352     *dx = MIN(*dx, (a->x + a->width) - (x + self->area.width));
353     *dy = MIN(*dy, (a->y + a->height) - (y + self->area.height));
354     /* if in the top half then check this stuff last, will keep the top
355        edge of the menu visible */
356     if (pos <= half) {
357         *dx = MAX(*dx, a->x - x);
358         *dy = MAX(*dy, a->y - y);
359     }
360 }
361
362 static void menu_entry_frame_render(ObMenuEntryFrame *self)
363 {
364     RrAppearance *item_a, *text_a;
365     gint th; /* temp */
366     ObMenu *sub;
367     ObMenuFrame *frame = self->frame;
368
369     switch (self->entry->type) {
370     case OB_MENU_ENTRY_TYPE_NORMAL:
371     case OB_MENU_ENTRY_TYPE_SUBMENU:
372         item_a = (self->entry->type == OB_MENU_ENTRY_TYPE_NORMAL &&
373                   !self->entry->data.normal.enabled ?
374                   /* disabled */
375                   (self == self->frame->selected ?
376                    ob_rr_theme->a_menu_disabled_selected :
377                    ob_rr_theme->a_menu_disabled) :
378                   /* enabled */
379                   (self == self->frame->selected ?
380                    ob_rr_theme->a_menu_selected :
381                    ob_rr_theme->a_menu_normal));
382         th = ITEM_HEIGHT;
383         break;
384     case OB_MENU_ENTRY_TYPE_SEPARATOR:
385         if (self->entry->data.separator.label) {
386             item_a = ob_rr_theme->a_menu_title;
387             th = ob_rr_theme->menu_title_height;
388         } else {
389             item_a = ob_rr_theme->a_menu_normal;
390             th = ob_rr_theme->menu_sep_width +
391                 2*ob_rr_theme->menu_sep_paddingy;
392         }
393         break;
394     default:
395         g_assert_not_reached();
396     }
397
398     RECT_SET_SIZE(self->area, self->frame->inner_w, th);
399     XResizeWindow(obt_display, self->window,
400                   self->area.width, self->area.height);
401     item_a->surface.parent = self->frame->a_items;
402     item_a->surface.parentx = self->area.x;
403     item_a->surface.parenty = self->area.y;
404     RrPaint(item_a, self->window, self->area.width, self->area.height);
405
406     switch (self->entry->type) {
407     case OB_MENU_ENTRY_TYPE_NORMAL:
408         text_a = (self->entry->type == OB_MENU_ENTRY_TYPE_NORMAL &&
409                   !self->entry->data.normal.enabled ?
410                   /* disabled */
411                   (self == self->frame->selected ?
412                    ob_rr_theme->a_menu_text_disabled_selected :
413                    ob_rr_theme->a_menu_text_disabled) :
414                   /* enabled */
415                   (self == self->frame->selected ?
416                    ob_rr_theme->a_menu_text_selected :
417                    ob_rr_theme->a_menu_text_normal));
418         text_a->texture[0].data.text.string = self->entry->data.normal.label;
419         if (self->entry->data.normal.shortcut &&
420             (self->frame->menu->show_all_shortcuts ||
421              self->entry->data.normal.shortcut_always_show ||
422              self->entry->data.normal.shortcut_position > 0))
423         {
424             text_a->texture[0].data.text.shortcut = TRUE;
425             text_a->texture[0].data.text.shortcut_pos =
426                 self->entry->data.normal.shortcut_position;
427         } else
428             text_a->texture[0].data.text.shortcut = FALSE;
429         break;
430     case OB_MENU_ENTRY_TYPE_SUBMENU:
431         text_a = (self == self->frame->selected ?
432                   ob_rr_theme->a_menu_text_selected :
433                   ob_rr_theme->a_menu_text_normal);
434         sub = self->entry->data.submenu.submenu;
435         text_a->texture[0].data.text.string = sub ? sub->title : "";
436         if (sub && sub->shortcut && (self->frame->menu->show_all_shortcuts ||
437                               sub->shortcut_always_show ||
438                               sub->shortcut_position > 0))
439         {
440             text_a->texture[0].data.text.shortcut = TRUE;
441             text_a->texture[0].data.text.shortcut_pos = sub->shortcut_position;
442         } else
443             text_a->texture[0].data.text.shortcut = FALSE;
444         break;
445     case OB_MENU_ENTRY_TYPE_SEPARATOR:
446         if (self->entry->data.separator.label != NULL) {
447             text_a = ob_rr_theme->a_menu_text_title;
448             text_a->texture[0].data.text.string =
449                 self->entry->data.separator.label;
450         }
451         else
452             text_a = ob_rr_theme->a_menu_text_normal;
453         break;
454     default:
455         g_assert_not_reached();
456     }
457
458     switch (self->entry->type) {
459     case OB_MENU_ENTRY_TYPE_NORMAL:
460         XMoveResizeWindow(obt_display, self->text,
461                           self->frame->text_x, PADDING,
462                           self->frame->text_w,
463                           ITEM_HEIGHT - 2*PADDING);
464         text_a->surface.parent = item_a;
465         text_a->surface.parentx = self->frame->text_x;
466         text_a->surface.parenty = PADDING;
467         RrPaint(text_a, self->text, self->frame->text_w,
468                 ITEM_HEIGHT - 2*PADDING);
469         break;
470     case OB_MENU_ENTRY_TYPE_SUBMENU:
471         XMoveResizeWindow(obt_display, self->text,
472                           self->frame->text_x, PADDING,
473                           self->frame->text_w - ITEM_HEIGHT,
474                           ITEM_HEIGHT - 2*PADDING);
475         text_a->surface.parent = item_a;
476         text_a->surface.parentx = self->frame->text_x;
477         text_a->surface.parenty = PADDING;
478         RrPaint(text_a, self->text, self->frame->text_w - ITEM_HEIGHT,
479                 ITEM_HEIGHT - 2*PADDING);
480         break;
481     case OB_MENU_ENTRY_TYPE_SEPARATOR:
482         if (self->entry->data.separator.label != NULL) {
483             /* labeled separator */
484             XMoveResizeWindow(obt_display, self->text,
485                               ob_rr_theme->paddingx, ob_rr_theme->paddingy,
486                               self->area.width - 2*ob_rr_theme->paddingx,
487                               ob_rr_theme->menu_title_height -
488                               2*ob_rr_theme->paddingy);
489             text_a->surface.parent = item_a;
490             text_a->surface.parentx = ob_rr_theme->paddingx;
491             text_a->surface.parenty = ob_rr_theme->paddingy;
492             RrPaint(text_a, self->text,
493                     self->area.width - 2*ob_rr_theme->paddingx,
494                     ob_rr_theme->menu_title_height -
495                     2*ob_rr_theme->paddingy);
496         } else {
497             gint i;
498
499             /* unlabeled separator */
500             XMoveResizeWindow(obt_display, self->text, 0, 0,
501                               self->area.width,
502                               ob_rr_theme->menu_sep_width +
503                               2*ob_rr_theme->menu_sep_paddingy);
504
505             a_sep->surface.parent = item_a;
506             a_sep->surface.parentx = 0;
507             a_sep->surface.parenty = 0;
508             for (i = 0; i < ob_rr_theme->menu_sep_width; ++i) {
509                 a_sep->texture[i].data.lineart.x1 =
510                     ob_rr_theme->menu_sep_paddingx;
511                 a_sep->texture[i].data.lineart.y1 =
512                     ob_rr_theme->menu_sep_paddingy + i;
513                 a_sep->texture[i].data.lineart.x2 =
514                     self->area.width - ob_rr_theme->menu_sep_paddingx - 1;
515                 a_sep->texture[i].data.lineart.y2 =
516                     ob_rr_theme->menu_sep_paddingy + i;
517             }
518
519             RrPaint(a_sep, self->text, self->area.width,
520                     ob_rr_theme->menu_sep_width +
521                     2*ob_rr_theme->menu_sep_paddingy);
522         }
523         break;
524     default:
525         g_assert_not_reached();
526     }
527
528     if (((self->entry->type == OB_MENU_ENTRY_TYPE_NORMAL) ||
529          (self->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU)) &&
530         self->entry->data.normal.icon)
531     {
532         RrAppearance *clear;
533
534         XMoveResizeWindow(obt_display, self->icon,
535                           PADDING, frame->item_margin.top,
536                           ITEM_HEIGHT - frame->item_margin.top
537                           - frame->item_margin.bottom,
538                           ITEM_HEIGHT - frame->item_margin.top
539                           - frame->item_margin.bottom);
540
541         clear = ob_rr_theme->a_clear_tex;
542         RrAppearanceClearTextures(clear);
543         clear->texture[0].type = RR_TEXTURE_IMAGE;
544         clear->texture[0].data.image.image =
545             self->entry->data.normal.icon;
546         clear->texture[0].data.image.alpha =
547             self->entry->data.normal.icon_alpha;
548         clear->surface.parent = item_a;
549         clear->surface.parentx = PADDING;
550         clear->surface.parenty = frame->item_margin.top;
551         RrPaint(clear, self->icon,
552                 ITEM_HEIGHT - frame->item_margin.top
553                 - frame->item_margin.bottom,
554                 ITEM_HEIGHT - frame->item_margin.top
555                 - frame->item_margin.bottom);
556         XMapWindow(obt_display, self->icon);
557     } else if (self->entry->type == OB_MENU_ENTRY_TYPE_NORMAL &&
558                self->entry->data.normal.mask)
559     {
560         RrColor *c;
561         RrAppearance *clear;
562
563         XMoveResizeWindow(obt_display, self->icon,
564                           PADDING, frame->item_margin.top,
565                           ITEM_HEIGHT - frame->item_margin.top
566                           - frame->item_margin.bottom,
567                           ITEM_HEIGHT - frame->item_margin.top
568                           - frame->item_margin.bottom);
569
570         clear = ob_rr_theme->a_clear_tex;
571         RrAppearanceClearTextures(clear);
572         clear->texture[0].type = RR_TEXTURE_MASK;
573         clear->texture[0].data.mask.mask =
574             self->entry->data.normal.mask;
575
576         c = (self->entry->type == OB_MENU_ENTRY_TYPE_NORMAL &&
577              !self->entry->data.normal.enabled ?
578              /* disabled */
579              (self == self->frame->selected ?
580               self->entry->data.normal.mask_disabled_selected_color :
581               self->entry->data.normal.mask_disabled_color) :
582              /* enabled */
583              (self == self->frame->selected ?
584               self->entry->data.normal.mask_selected_color :
585               self->entry->data.normal.mask_normal_color));
586         clear->texture[0].data.mask.color = c;
587
588         clear->surface.parent = item_a;
589         clear->surface.parentx = PADDING;
590         clear->surface.parenty = frame->item_margin.top;
591         RrPaint(clear, self->icon,
592                 ITEM_HEIGHT - frame->item_margin.top
593                 - frame->item_margin.bottom,
594                 ITEM_HEIGHT - frame->item_margin.top
595                 - frame->item_margin.bottom);
596         XMapWindow(obt_display, self->icon);
597     } else
598         XUnmapWindow(obt_display, self->icon);
599
600     if (self->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU) {
601         RrAppearance *bullet_a;
602         XMoveResizeWindow(obt_display, self->bullet,
603                           self->frame->text_x + self->frame->text_w -
604                           ITEM_HEIGHT + PADDING, PADDING,
605                           ITEM_HEIGHT - 2*PADDING,
606                           ITEM_HEIGHT - 2*PADDING);
607         bullet_a = (self == self->frame->selected ?
608                     ob_rr_theme->a_menu_bullet_selected :
609                     ob_rr_theme->a_menu_bullet_normal);
610         bullet_a->surface.parent = item_a;
611         bullet_a->surface.parentx =
612             self->frame->text_x + self->frame->text_w - ITEM_HEIGHT + PADDING;
613         bullet_a->surface.parenty = PADDING;
614         RrPaint(bullet_a, self->bullet,
615                 ITEM_HEIGHT - 2*PADDING,
616                 ITEM_HEIGHT - 2*PADDING);
617         XMapWindow(obt_display, self->bullet);
618     } else
619         XUnmapWindow(obt_display, self->bullet);
620
621     XFlush(obt_display);
622 }
623
624 /*! this code is taken from the menu_frame_render. if that changes, this won't
625   work.. */
626 static gint menu_entry_frame_get_height(ObMenuEntryFrame *self,
627                                         gboolean first_entry,
628                                         gboolean last_entry)
629 {
630     ObMenuEntryType t;
631     gint h = 0;
632
633     h += 2*PADDING;
634
635     if (self)
636         t = self->entry->type;
637     else
638         /* this is the More... entry, it's NORMAL type */
639         t = OB_MENU_ENTRY_TYPE_NORMAL;
640
641     switch (t) {
642     case OB_MENU_ENTRY_TYPE_NORMAL:
643     case OB_MENU_ENTRY_TYPE_SUBMENU:
644         h += ob_rr_theme->menu_font_height;
645         break;
646     case OB_MENU_ENTRY_TYPE_SEPARATOR:
647         if (self->entry->data.separator.label != NULL) {
648             h += ob_rr_theme->menu_title_height +
649                 (ob_rr_theme->mbwidth - PADDING) * 2;
650
651             /* if the first entry is a labeled separator, then make its border
652                overlap with the menu's outside border */
653             if (first_entry)
654                 h -= ob_rr_theme->mbwidth;
655             /* if the last entry is a labeled separator, then make its border
656                overlap with the menu's outside border */
657             if (last_entry)
658                 h -= ob_rr_theme->mbwidth;
659         } else {
660             h += ob_rr_theme->menu_sep_width +
661                 2*ob_rr_theme->menu_sep_paddingy - PADDING * 2;
662         }
663         break;
664     }
665
666     return h;
667 }
668
669 void menu_frame_render(ObMenuFrame *self)
670 {
671     gint w = 0, h = 0;
672     gint tw, th; /* temps */
673     GList *it;
674     gboolean has_icon = FALSE;
675     ObMenu *sub;
676     ObMenuEntryFrame *e;
677
678     /* find text dimensions */
679
680     STRUT_SET(self->item_margin, 0, 0, 0, 0);
681
682     if (self->entries) {
683         gint l, t, r, b;
684
685         e = self->entries->data;
686         ob_rr_theme->a_menu_text_normal->texture[0].data.text.string = "";
687         tw = RrMinWidth(ob_rr_theme->a_menu_text_normal);
688         tw += 2*PADDING;
689
690         th = ITEM_HEIGHT;
691
692         RrMargins(ob_rr_theme->a_menu_normal, &l, &t, &r, &b);
693         STRUT_SET(self->item_margin,
694                   MAX(self->item_margin.left, l),
695                   MAX(self->item_margin.top, t),
696                   MAX(self->item_margin.right, r),
697                   MAX(self->item_margin.bottom, b));
698         RrMargins(ob_rr_theme->a_menu_selected, &l, &t, &r, &b);
699         STRUT_SET(self->item_margin,
700                   MAX(self->item_margin.left, l),
701                   MAX(self->item_margin.top, t),
702                   MAX(self->item_margin.right, r),
703                   MAX(self->item_margin.bottom, b));
704         RrMargins(ob_rr_theme->a_menu_disabled, &l, &t, &r, &b);
705         STRUT_SET(self->item_margin,
706                   MAX(self->item_margin.left, l),
707                   MAX(self->item_margin.top, t),
708                   MAX(self->item_margin.right, r),
709                   MAX(self->item_margin.bottom, b));
710         RrMargins(ob_rr_theme->a_menu_disabled_selected, &l, &t, &r, &b);
711         STRUT_SET(self->item_margin,
712                   MAX(self->item_margin.left, l),
713                   MAX(self->item_margin.top, t),
714                   MAX(self->item_margin.right, r),
715                   MAX(self->item_margin.bottom, b));
716     }
717
718     /* render the entries */
719
720     for (it = self->entries; it; it = g_list_next(it)) {
721         RrAppearance *text_a;
722         e = it->data;
723
724         /* if the first entry is a labeled separator, then make its border
725            overlap with the menu's outside border */
726         if (it == self->entries &&
727             e->entry->type == OB_MENU_ENTRY_TYPE_SEPARATOR &&
728             e->entry->data.separator.label)
729         {
730             h -= ob_rr_theme->mbwidth;
731         }
732
733         if (e->entry->type == OB_MENU_ENTRY_TYPE_SEPARATOR &&
734             e->entry->data.separator.label)
735         {
736             e->border = ob_rr_theme->mbwidth;
737         }
738
739         RECT_SET_POINT(e->area, 0, h+e->border);
740         XMoveWindow(obt_display, e->window,
741                     e->area.x-e->border, e->area.y-e->border);
742         XSetWindowBorderWidth(obt_display, e->window, e->border);
743         XSetWindowBorder(obt_display, e->window,
744                          RrColorPixel(ob_rr_theme->menu_border_color));
745
746         text_a = (e->entry->type == OB_MENU_ENTRY_TYPE_NORMAL &&
747                   !e->entry->data.normal.enabled ?
748                   /* disabled */
749                   (e == self->selected ?
750                    ob_rr_theme->a_menu_text_disabled_selected :
751                    ob_rr_theme->a_menu_text_disabled) :
752                   /* enabled */
753                   (e == self->selected ?
754                    ob_rr_theme->a_menu_text_selected : 
755                    ob_rr_theme->a_menu_text_normal));
756         switch (e->entry->type) {
757         case OB_MENU_ENTRY_TYPE_NORMAL:
758             text_a->texture[0].data.text.string = e->entry->data.normal.label;
759             tw = RrMinWidth(text_a);
760             tw = MIN(tw, MAX_MENU_WIDTH);
761             th = ob_rr_theme->menu_font_height;
762
763             if (e->entry->data.normal.icon ||
764                 e->entry->data.normal.mask)
765                 has_icon = TRUE;
766             break;
767         case OB_MENU_ENTRY_TYPE_SUBMENU:
768             sub = e->entry->data.submenu.submenu;
769             text_a->texture[0].data.text.string = sub ? sub->title : "";
770             tw = RrMinWidth(text_a);
771             tw = MIN(tw, MAX_MENU_WIDTH);
772             th = ob_rr_theme->menu_font_height;
773
774             if (e->entry->data.normal.icon ||
775                 e->entry->data.normal.mask)
776                 has_icon = TRUE;
777
778             tw += ITEM_HEIGHT - PADDING;
779             break;
780         case OB_MENU_ENTRY_TYPE_SEPARATOR:
781             if (e->entry->data.separator.label != NULL) {
782                 ob_rr_theme->a_menu_text_title->texture[0].data.text.string =
783                     e->entry->data.separator.label;
784                 tw = RrMinWidth(ob_rr_theme->a_menu_text_title) +
785                     2*ob_rr_theme->paddingx;
786                 tw = MIN(tw, MAX_MENU_WIDTH);
787                 th = ob_rr_theme->menu_title_height +
788                     (ob_rr_theme->mbwidth - PADDING) *2;
789             } else {
790                 tw = 0;
791                 th = ob_rr_theme->menu_sep_width +
792                     2*ob_rr_theme->menu_sep_paddingy - 2*PADDING;
793             }
794             break;
795         default:
796             g_assert_not_reached();
797         }
798         tw += 2*PADDING;
799         th += 2*PADDING;
800         w = MAX(w, tw);
801         h += th;
802     }
803
804     /* if the last entry is a labeled separator, then make its border
805        overlap with the menu's outside border */
806     it = g_list_last(self->entries);
807     e = it ? it->data : NULL;
808     if (e && e->entry->type == OB_MENU_ENTRY_TYPE_SEPARATOR &&
809         e->entry->data.separator.label)
810     {
811         h -= ob_rr_theme->mbwidth;
812     }
813
814     self->text_x = PADDING;
815     self->text_w = w;
816
817     if (self->entries) {
818         if (has_icon) {
819             w += ITEM_HEIGHT + PADDING;
820             self->text_x += ITEM_HEIGHT + PADDING;
821         }
822     }
823
824     if (!w) w = 10;
825     if (!h) h = 3;
826
827     XResizeWindow(obt_display, self->window, w, h);
828
829     self->inner_w = w;
830
831     RrPaint(self->a_items, self->window, w, h);
832
833     for (it = self->entries; it; it = g_list_next(it))
834         menu_entry_frame_render(it->data);
835
836     w += ob_rr_theme->mbwidth * 2;
837     h += ob_rr_theme->mbwidth * 2;
838
839     RECT_SET_SIZE(self->area, w, h);
840
841     XFlush(obt_display);
842 }
843
844 static void menu_frame_update(ObMenuFrame *self)
845 {
846     GList *mit, *fit;
847     const Rect *a;
848     gint h;
849
850     menu_pipe_execute(self->menu);
851     menu_find_submenus(self->menu);
852
853     self->selected = NULL;
854
855     /* start at show_from */
856     mit = g_list_nth(self->menu->entries, self->show_from);
857
858     /* go through the menu's and frame's entries and connect the frame entries
859        to the menu entries */
860     for (fit = self->entries; mit && fit;
861          mit = g_list_next(mit), fit = g_list_next(fit))
862     {
863         ObMenuEntryFrame *f = fit->data;
864         f->entry = mit->data;
865     }
866
867     /* if there are more menu entries than in the frame, add them */
868     while (mit) {
869         ObMenuEntryFrame *e = menu_entry_frame_new(mit->data, self);
870         self->entries = g_list_append(self->entries, e);
871         mit = g_list_next(mit);
872     }
873
874     /* if there are more frame entries than menu entries then get rid of
875        them */
876     while (fit) {
877         GList *n = g_list_next(fit);
878         menu_entry_frame_free(fit->data);
879         self->entries = g_list_delete_link(self->entries, fit);
880         fit = n;
881     }
882
883     /* * make the menu fit on the screen */
884
885     /* calculate the height of the menu */
886     h = 0;
887     for (fit = self->entries; fit; fit = g_list_next(fit))
888         h += menu_entry_frame_get_height(fit->data,
889                                          fit == self->entries,
890                                          g_list_next(fit) == NULL);
891     /* add the border at the top and bottom */
892     h += ob_rr_theme->mbwidth * 2;
893
894     a = screen_physical_area_monitor(self->monitor);
895
896     if (h > a->height) {
897         GList *flast, *tmp;
898         gboolean last_entry = TRUE;
899
900         /* take the height of our More... entry into account */
901         h += menu_entry_frame_get_height(NULL, FALSE, TRUE);
902
903         /* start at the end of the entries */
904         flast = g_list_last(self->entries);
905
906         /* pull out all the entries from the frame that don't
907            fit on the screen, leaving at least 1 though */
908         while (h > a->height && g_list_previous(flast) != NULL) {
909             /* update the height, without this entry */
910             h -= menu_entry_frame_get_height(flast->data, FALSE, last_entry);
911
912             /* destroy the entry we're not displaying */
913             tmp = flast;
914             flast = g_list_previous(flast);
915             menu_entry_frame_free(tmp->data);
916             self->entries = g_list_delete_link(self->entries, tmp);
917
918             /* only the first one that we see is the last entry in the menu */
919             last_entry = FALSE;
920         };
921
922         {
923             ObMenuEntry *more_entry;
924             ObMenuEntryFrame *more_frame;
925             /* make the More... menu entry frame which will display in this
926                frame.
927                if self->menu->more_menu is NULL that means that this is already
928                More... menu, so just use ourself.
929             */
930             more_entry = menu_get_more((self->menu->more_menu ?
931                                         self->menu->more_menu :
932                                         self->menu),
933                                        /* continue where we left off */
934                                        self->show_from +
935                                        g_list_length(self->entries));
936             more_frame = menu_entry_frame_new(more_entry, self);
937             /* make it get deleted when the menu frame goes away */
938             menu_entry_unref(more_entry);
939
940             /* add our More... entry to the frame */
941             self->entries = g_list_append(self->entries, more_frame);
942         }
943     }
944
945     menu_frame_render(self);
946 }
947
948 static gboolean menu_frame_is_visible(ObMenuFrame *self)
949 {
950     return !!(g_list_find(menu_frame_visible, self));
951 }
952
953 static gboolean menu_frame_show(ObMenuFrame *self)
954 {
955     GList *it;
956
957     /* determine if the underlying menu is already visible */
958     for (it = menu_frame_visible; it; it = g_list_next(it)) {
959         ObMenuFrame *f = it->data;
960         if (f->menu == self->menu)
961             break;
962     }
963     if (!it) {
964         if (self->menu->update_func)
965             if (!self->menu->update_func(self, self->menu->data))
966                 return FALSE;
967     }
968
969     if (menu_frame_visible == NULL) {
970         /* no menus shown yet */
971
972         /* grab the pointer in such a way as to pass through "owner events"
973            so that we can get enter/leave notifies in the menu. */
974         if (!grab_pointer(TRUE, FALSE, OB_CURSOR_POINTER))
975             return FALSE;
976         if (!grab_keyboard()) {
977             ungrab_pointer();
978             return FALSE;
979         }
980     }
981
982     menu_frame_update(self);
983
984     menu_frame_visible = g_list_prepend(menu_frame_visible, self);
985
986     if (self->menu->show_func)
987         self->menu->show_func(self, self->menu->data);
988
989     return TRUE;
990 }
991
992 gboolean menu_frame_show_topmenu(ObMenuFrame *self, gint x, gint y,
993                                  gboolean mouse)
994 {
995     gint px, py;
996
997     if (menu_frame_is_visible(self))
998         return TRUE;
999     if (!menu_frame_show(self))
1000         return FALSE;
1001
1002     if (self->menu->place_func)
1003         self->menu->place_func(self, &x, &y, mouse, self->menu->data);
1004     else
1005         menu_frame_place_topmenu(self, &x, &y);
1006
1007     menu_frame_move(self, x, y);
1008
1009     XMapWindow(obt_display, self->window);
1010
1011     if (screen_pointer_pos(&px, &py)) {
1012         ObMenuEntryFrame *e = menu_entry_frame_under(px, py);
1013         if (e && e->frame == self)
1014             e->ignore_enters++;
1015     }
1016
1017     return TRUE;
1018 }
1019
1020 /*! Stop hiding an open submenu.
1021     @child The OnMenuFrame of the submenu to be hidden
1022 */
1023 static void remove_submenu_hide_timeout(ObMenuFrame *child)
1024 {
1025     if (submenu_hide_timer) g_source_remove(submenu_hide_timer);
1026     submenu_hide_timer = 0;
1027 }
1028
1029 gboolean menu_frame_show_submenu(ObMenuFrame *self, ObMenuFrame *parent,
1030                                  ObMenuEntryFrame *parent_entry)
1031 {
1032     gint x, y, dx, dy;
1033     gint px, py;
1034
1035     if (menu_frame_is_visible(self))
1036         return TRUE;
1037
1038     self->monitor = parent->monitor;
1039     self->parent = parent;
1040     self->parent_entry = parent_entry;
1041
1042     /* set up parent's child to be us */
1043     if ((parent->child) != self) {
1044         if (parent->child)
1045             menu_frame_hide(parent->child);
1046         parent->child = self;
1047         parent->child_entry = parent_entry;
1048     }
1049
1050     if (!menu_frame_show(self)) {
1051         parent->child = NULL;
1052         parent->child_entry = NULL;
1053         return FALSE;
1054     }
1055
1056     menu_frame_place_submenu(self, &x, &y);
1057     menu_frame_move_on_screen(self, x, y, &dx, &dy);
1058
1059     if (dx != 0) {
1060         /*try the other side */
1061         self->direction_right = !self->direction_right;
1062         menu_frame_place_submenu(self, &x, &y);
1063         menu_frame_move_on_screen(self, x, y, &dx, &dy);
1064     }
1065     menu_frame_move(self, x + dx, y + dy);
1066
1067     XMapWindow(obt_display, self->window);
1068
1069     if (screen_pointer_pos(&px, &py)) {
1070         ObMenuEntryFrame *e = menu_entry_frame_under(px, py);
1071         if (e && e->frame == self)
1072             e->ignore_enters++;
1073     }
1074
1075     return TRUE;
1076 }
1077
1078 static void menu_frame_hide(ObMenuFrame *self)
1079 {
1080     ObMenu *const menu = self->menu;
1081     GList *it = g_list_find(menu_frame_visible, self);
1082     gulong ignore_start;
1083
1084     if (!it)
1085         return;
1086
1087     if (menu->hide_func)
1088         menu->hide_func(self, menu->data);
1089
1090     if (self->child)
1091         menu_frame_hide(self->child);
1092
1093     if (self->parent) {
1094         remove_submenu_hide_timeout(self);
1095
1096         self->parent->child = NULL;
1097         self->parent->child_entry = NULL;
1098     }
1099     self->parent = NULL;
1100     self->parent_entry = NULL;
1101
1102     menu_frame_visible = g_list_delete_link(menu_frame_visible, it);
1103
1104     if (menu_frame_visible == NULL) {
1105         /* last menu shown */
1106         ungrab_pointer();
1107         ungrab_keyboard();
1108     }
1109
1110     ignore_start = event_start_ignore_all_enters();
1111     XUnmapWindow(obt_display, self->window);
1112     event_end_ignore_all_enters(ignore_start);
1113
1114     menu_frame_free(self);
1115
1116     if (menu->cleanup_func)
1117         menu->cleanup_func(menu, menu->data);
1118 }
1119
1120 void menu_frame_hide_all(void)
1121 {
1122     GList *it;
1123
1124     if (config_submenu_show_delay) {
1125         /* remove any submenu open requests */
1126         if (submenu_show_timer) g_source_remove(submenu_show_timer);
1127         submenu_show_timer = 0;
1128     }
1129     if ((it = g_list_last(menu_frame_visible)))
1130         menu_frame_hide(it->data);
1131 }
1132
1133 ObMenuFrame* menu_frame_under(gint x, gint y)
1134 {
1135     ObMenuFrame *ret = NULL;
1136     GList *it;
1137
1138     for (it = menu_frame_visible; it; it = g_list_next(it)) {
1139         ObMenuFrame *f = it->data;
1140
1141         if (RECT_CONTAINS(f->area, x, y)) {
1142             ret = f;
1143             break;
1144         }
1145     }
1146     return ret;
1147 }
1148
1149 ObMenuEntryFrame* menu_entry_frame_under(gint x, gint y)
1150 {
1151     ObMenuFrame *frame;
1152     ObMenuEntryFrame *ret = NULL;
1153     GList *it;
1154
1155     if ((frame = menu_frame_under(x, y))) {
1156         x -= ob_rr_theme->mbwidth + frame->area.x;
1157         y -= ob_rr_theme->mbwidth + frame->area.y;
1158
1159         for (it = frame->entries; it; it = g_list_next(it)) {
1160             ObMenuEntryFrame *e = it->data;
1161
1162             if (RECT_CONTAINS(e->area, x, y)) {
1163                 ret = e;
1164                 break;
1165             }
1166         }
1167     }
1168     return ret;
1169 }
1170
1171 static gboolean submenu_show_timeout(gpointer data)
1172 {
1173     g_assert(menu_frame_visible);
1174     menu_entry_frame_show_submenu((ObMenuEntryFrame*)data);
1175     return FALSE;
1176 }
1177
1178 static gboolean submenu_hide_timeout(gpointer data)
1179 {
1180     g_assert(menu_frame_visible);
1181     menu_frame_hide((ObMenuFrame*)data);
1182     return FALSE;
1183 }
1184
1185 void menu_frame_select(ObMenuFrame *self, ObMenuEntryFrame *entry,
1186                        gboolean immediate)
1187 {
1188     ObMenuEntryFrame *old = self->selected;
1189     ObMenuFrame *oldchild = self->child;
1190     ObMenuEntryFrame *oldchild_entry = self->child_entry;
1191
1192     /* if the user selected a separator, ignore it and reselect what we had
1193        selected before */
1194     if (entry && entry->entry->type == OB_MENU_ENTRY_TYPE_SEPARATOR)
1195         entry = old;
1196
1197     if (old == entry &&
1198         (!old || old->entry->type != OB_MENU_ENTRY_TYPE_SUBMENU))
1199         return;
1200
1201     /* if the user left this menu but we have a submenu open, move the
1202        selection back to that submenu */
1203     if (!entry && oldchild_entry)
1204         entry = oldchild_entry;
1205
1206     if (config_submenu_show_delay) {
1207         /* remove any submenu open requests */
1208         if (submenu_show_timer) g_source_remove(submenu_show_timer);
1209         submenu_show_timer = 0;
1210     }
1211
1212     self->selected = entry;
1213
1214     if (old)
1215         menu_entry_frame_render(old);
1216
1217     if (oldchild_entry) {
1218         /* There is an open submenu */
1219         if (oldchild_entry == self->selected) {
1220             /* The open submenu has been reselected, so stop hiding the
1221                submenu */
1222             remove_submenu_hide_timeout(oldchild);
1223         }
1224         else if (oldchild_entry == old) {
1225             /* The open submenu was selected and is no longer, so hide the
1226                submenu */
1227             if (immediate || config_submenu_hide_delay == 0)
1228                 menu_frame_hide(oldchild);
1229             else if (config_submenu_hide_delay > 0) {
1230                 if (submenu_hide_timer) g_source_remove(submenu_hide_timer);
1231                 submenu_hide_timer =
1232                     g_timeout_add_full(G_PRIORITY_DEFAULT,
1233                                        config_submenu_hide_delay,
1234                                        submenu_hide_timeout, oldchild, NULL);
1235             }
1236         }
1237     }
1238
1239     if (self->selected) {
1240         menu_entry_frame_render(self->selected);
1241
1242         if (self->selected->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU) {
1243             /* only show if the submenu isn't already showing */
1244             if (oldchild_entry != self->selected) {
1245                 if (immediate || config_submenu_show_delay == 0)
1246                     menu_entry_frame_show_submenu(self->selected);
1247                 else if (config_submenu_show_delay > 0) {
1248                     if (submenu_show_timer)
1249                         g_source_remove(submenu_show_timer);
1250                     submenu_show_timer =
1251                         g_timeout_add_full(G_PRIORITY_DEFAULT,
1252                                            config_submenu_show_delay,
1253                                            submenu_show_timeout,
1254                                            self->selected, NULL);
1255                 }
1256             }
1257             /* hide the grandchildren of this menu. and move the cursor to
1258                the current menu */
1259             else if (immediate && self->child && self->child->child) {
1260                 menu_frame_hide(self->child->child);
1261                 menu_frame_select(self->child, NULL, TRUE);
1262             }
1263         }
1264     }
1265 }
1266
1267 void menu_entry_frame_show_submenu(ObMenuEntryFrame *self)
1268 {
1269     ObMenuFrame *f;
1270
1271     if (!self->entry->data.submenu.submenu) return;
1272
1273     f = menu_frame_new(self->entry->data.submenu.submenu,
1274                        self->entry->data.submenu.show_from,
1275                        self->frame->client);
1276     /* pass our direction on to our child */
1277     f->direction_right = self->frame->direction_right;
1278
1279     if (!menu_frame_show_submenu(f, self->frame, self))
1280         menu_frame_free(f);
1281 }
1282
1283 void menu_entry_frame_execute(ObMenuEntryFrame *self, guint state)
1284 {
1285     if (self->entry->type == OB_MENU_ENTRY_TYPE_NORMAL &&
1286         self->entry->data.normal.enabled)
1287     {
1288         /* grab all this shizzle, cuz when the menu gets hidden, 'self'
1289            gets freed */
1290         ObMenuEntry *entry = self->entry;
1291         ObMenuExecuteFunc func = self->frame->menu->execute_func;
1292         gpointer data = self->frame->menu->data;
1293         GSList *acts = self->entry->data.normal.actions;
1294         ObClient *client = self->frame->client;
1295         ObMenuFrame *frame = self->frame;
1296         guint mods = obt_keyboard_only_modmasks(state);
1297
1298         /* release grabs before executing the shit */
1299         if (!(mods & ControlMask)) {
1300             event_cancel_all_key_grabs();
1301             frame = NULL;
1302         }
1303
1304         if (func)
1305             func(entry, frame, client, state, data);
1306         else
1307             actions_run_acts(acts, OB_USER_ACTION_MENU_SELECTION,
1308                              state, -1, -1, 0, OB_FRAME_CONTEXT_NONE, client);
1309     }
1310 }
1311
1312 void menu_frame_select_previous(ObMenuFrame *self)
1313 {
1314     GList *it = NULL, *start;
1315
1316     if (self->entries) {
1317         start = it = g_list_find(self->entries, self->selected);
1318         while (TRUE) {
1319             ObMenuEntryFrame *e;
1320
1321             it = it ? g_list_previous(it) : g_list_last(self->entries);
1322             if (it == start)
1323                 break;
1324
1325             if (it) {
1326                 e = it->data;
1327                 if (e->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU)
1328                     break;
1329                 if (e->entry->type == OB_MENU_ENTRY_TYPE_NORMAL)
1330                     break;
1331             }
1332         }
1333     }
1334     menu_frame_select(self, it ? it->data : NULL, FALSE);
1335 }
1336
1337 void menu_frame_select_next(ObMenuFrame *self)
1338 {
1339     GList *it = NULL, *start;
1340
1341     if (self->entries) {
1342         start = it = g_list_find(self->entries, self->selected);
1343         while (TRUE) {
1344             ObMenuEntryFrame *e;
1345
1346             it = it ? g_list_next(it) : self->entries;
1347             if (it == start)
1348                 break;
1349
1350             if (it) {
1351                 e = it->data;
1352                 if (e->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU)
1353                     break;
1354                 if (e->entry->type == OB_MENU_ENTRY_TYPE_NORMAL)
1355                     break;
1356             }
1357         }
1358     }
1359     menu_frame_select(self, it ? it->data : NULL, FALSE);
1360 }
1361
1362 void menu_frame_select_first(ObMenuFrame *self)
1363 {
1364     GList *it = NULL;
1365
1366     if (self->entries) {
1367         for (it = self->entries; it; it = g_list_next(it)) {
1368             ObMenuEntryFrame *e = it->data;
1369             if (e->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU)
1370                 break;
1371             if (e->entry->type == OB_MENU_ENTRY_TYPE_NORMAL)
1372                 break;
1373         }
1374     }
1375     menu_frame_select(self, it ? it->data : NULL, FALSE);
1376 }
1377
1378 void menu_frame_select_last(ObMenuFrame *self)
1379 {
1380     GList *it = NULL;
1381
1382     if (self->entries) {
1383         for (it = g_list_last(self->entries); it; it = g_list_previous(it)) {
1384             ObMenuEntryFrame *e = it->data;
1385             if (e->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU)
1386                 break;
1387             if (e->entry->type == OB_MENU_ENTRY_TYPE_NORMAL)
1388                 break;
1389         }
1390     }
1391     menu_frame_select(self, it ? it->data : NULL, FALSE);
1392 }